Add-remove favorite link bug May 15, 2006 12:34 PM   Subscribe

I just went to remove a favorite, and while it successfully removes it, it continues to redirect to the same URL forever. It looks like the "add favorite" link for posts (but not comments) tries to do the same thing, but stops after one reload to tell me that the favorite has already been added.
posted by mendel to Bugs at 12:34 PM (8 comments total)

Yeah, the server is sending the header:
    Refresh: 0; URL=
posted by mendel at 12:39 PM on May 15, 2006

huh? I haven't seen this behavior. I can remove a favorite just fine.
posted by mathowie (staff) at 12:46 PM on May 15, 2006

Also: On the blue, clicking add to favorites pops open in a new browser window. On the green it does not.

Just for me, of course, maybe not everyone else. I do have links popping to a new window as an option set, but I'm not sure if favorites should do this. Either way the behavior isn't consistent between green/blue.

Still awesometastic feature additions as of late, so.. don't mean to sound like I'm only complaining... good stuff!
posted by twiggy at 12:47 PM on May 15, 2006

After you remove something, you should get redirected to the favorites page, with the favorite removed. That's what happens for me.
posted by mathowie (staff) at 12:47 PM on May 15, 2006

Aha, I see what's up. I'm blocking referers -- you must be redirecting back to whatever the referer was in both cases (which in my case is empty, which means it redirects back to the same page). It should probably not add the redirect at all if it's redirecting to "", or maybe it could just redirect back to the actual favorites URL on removal or the thread that was bookmarked as a favorite on adding a favorite.

With referer turned back on, it works as you described.
posted by mendel at 1:03 PM on May 15, 2006

Although this has been resolved, it might be a good idea to add a link back to the favorites page on the referring page, for other people in this situation.
posted by gsteff at 9:31 AM on May 16, 2006

It's not resolved for me! I turn referrer off intentionally, and there's no reason for that to require a referer to figure out where to redirect back to. Even javascript back() would work better.

A link won't help there because you don't get a chance to click on it; it redirects to itself with zero delay.
posted by mendel at 9:41 AM on May 16, 2006

Er, go.history(-1), not back().
posted by mendel at 9:42 AM on May 16, 2006

« Older Can we hold you to that?   |   Comment deletion in the religion thread. Newer »

You are not logged in, either login or create an account to post comments