What broke Mefiquote?

June 27, 2013 10:06 AM

Was there a recent change that would have semi-broken Plutor's Mefiquote script?

The script normally hyperlinks the username for the quoted person. Now it just gives the value: %n

Fully understood Metafilter is not responsible for Greasemonkey stuff, just wondered if you might know of a change to something that would be the cause.

And I know lots of people use the script, so thought this might be valuable for them. I confess to intentionally not using the contact form.

posted by Chrysostom to MetaFilter-Related at 10:06 AM (17 comments total)

It doesn't quote/attribute comments correctly anymore. Like this one:

%n: " Believe me, the IRS will tell you precisely how to give them your gay married monies by the time Tax Day rolls around."

But if you quote posts, it works properly.

Chrysostom: " The script normally hyperlinks the username for the quoted person. Now it just gives the value: %n"
posted by zarq at 10:17 AM on June 27, 2013

zarq: "But if you quote posts, it works properly. "

Hm, I just used it to quote your comment zarq, and it seemed to work?
posted by Grither at 10:19 AM on June 27, 2013

FWIW, I'm on Chrome Version 27.0.1453.116 m
posted by Grither at 10:20 AM on June 27, 2013

Grither: " Hm, I just used it to quote your comment zarq, and it seemed to work?"

Aaaaaand now it's working. :P

I expect pb will be along shortly to tell us how he fixed it on the back end.
posted by zarq at 10:21 AM on June 27, 2013

It works in MetaTalk, but not MetaFilter. We're in process of making some changes across the site to support viewing the site securely. Part of that is moving to protocol-relative URLs. So instead of hard-coding the http:// or https:// part of the URL for internal links, we're starting to use // only. The scripts probably aren't expecting that.

I'm guessing it'd be a quick tweak to get this working with the new URLs.
posted by pb (staff) at 10:27 AM on June 27, 2013

I'm looking at the source of the script now and spotted this line:

var path = url.replace(/https?:\/\/([^\/]*\.)?metafilter.com/, '');

I bet if you change that to:

var path = url.replace(/\/\/([^\/]*\.)?metafilter.com/, '');

It'll fix things up. But I haven't tried it.
posted by pb (staff) at 10:29 AM on June 27, 2013 [1 favorite]

That works.
posted by invitapriore at 10:31 AM on June 27, 2013

pb: "We're in process of making some changes across the site to support viewing the site securely."

ooh, neat!
posted by boo_radley at 10:31 AM on June 27, 2013 [1 favorite]

Thanks, pb!
posted by Chrysostom at 10:39 AM on June 27, 2013

We're in process of making some changes across the site to support viewing the site securely.

This is awesome. Thanks for doing it.
posted by Aizkolari at 10:40 AM on June 27, 2013 [1 favorite]

Check if you have a pop-up blocker. For some reason the script won't work for me when Better Pop Up Blocker is blocking MetaFilter. Not that that is necessarily relevant at this point.
posted by charred husk at 11:00 AM on June 27, 2013

Did pb's suggested change work for you guys? After changing that line, I'm still getting the n% on various subsites, both comment and post.

Running Firefox 22, if relevant.

I dropped Plutor a line, too.
posted by Chrysostom at 11:21 AM on June 27, 2013

While we're on this, didn't there use to be a box in your preferences that let you set the preferred format for the quote? I can't find it anymore.
posted by capricorn at 11:29 AM on June 27, 2013

I just made the change back to protocol-explicit URLs. So the script should be working again. As far as the URLs go.
posted by pb (staff) at 2:46 PM on June 27, 2013

capricorn: "While we're on this, didn't there use to be a box in your preferences that let you set the preferred format for the quote? I can't find it anymore."

Not that I know of.
posted by IndigoRain at 3:43 PM on June 28, 2013

I remember that in edit preferences.
posted by double block and bleed at 9:46 PM on June 28, 2013

FWIW, I remember that too.
posted by barnacles at 6:02 PM on June 30, 2013